This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[incremental] Patch: FYI: remove a FIXME


I'm checking this in on the incremental-compiler branch.

This removes a FIXME by changing where the hunk binding map is
initialized.  With threads we want to initialize in once, but for now
initializing it with the rest of the parser works fine.

Tom

ChangeLog:
2007-11-08  Tom Tromey  <tromey@redhat.com>

	* c-parser.c (c_parse_init): Call create_hunk_binding_map here...
	(c_parse_file): ... not here.

Index: c-parser.c
===================================================================
--- c-parser.c	(revision 130010)
+++ c-parser.c	(working copy)
@@ -181,6 +181,8 @@
 };
 #define N_reswords (sizeof reswords / sizeof (struct resword))
 
+static void create_hunk_binding_map (void);
+
 /* Initialization routine for this file.  */
 
 void
@@ -209,6 +211,8 @@
       C_IS_RESERVED_WORD (id) = 1;
       ridpointers [(int) reswords[i].rid] = id;
     }
+
+  create_hunk_binding_map ();
 }
 
 /* The C lexer intermediates between the lexer in cpplib and c-lex.c
@@ -8873,9 +8877,6 @@
   the_parser->smash_map = htab_create_ggc (20, hash_smash_entry, eq_smash_entry,
 					   NULL);
 
-  /* FIXME: should be in ordinary module initialization.  */
-  create_hunk_binding_map ();
-
   c_parser_lex_all (the_parser);
   c_parser_translation_unit (the_parser);
   the_parser = NULL;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]