This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: fix column numbers in C parser errors


On Tue, Nov 06, 2007 at 09:36:36PM -0700, Tom Tromey wrote:
> I adopted a simple rule while writing this patch: all calls to error
> functions (error, warning, and the pedwarn family) in c-parser.c must
> provide a location using %H.  This is simple to understand and forces
> the author of the call to think about which location is appropriate.

I'm sure this has come up before, but are there any error reporting
functions that take the location directly without the %H?  Should
there be?

Not only will this invalidate a lot of existing translations, but
it's also pretty confusing to read the new strings, IMVHO.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]