This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: make mapped locations the default
- From: Tom Tromey <tromey at redhat dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Eric Botcazou <ebotcazou at adacore dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sun, 04 Nov 2007 17:41:02 -0700
- Subject: Re: Patch: make mapped locations the default
- References: <m3myu6bi2u.fsf@fleche.redhat.com> <200710260742.20014.ebotcazou@adacore.com> <m37il375dv.fsf@fleche.redhat.com> <200710312013.32515.ebotcazou@adacore.com> <472E5711.7000802@codesourcery.com>
- Reply-to: tromey at redhat dot com
>>>>> "Mark" == Mark Mitchell <mark@codesourcery.com> writes:
Mark> Eric Botcazou wrote:
>>> I did this and it passed.
>>
>> Neat. :-) Thanks for the testing.
Mark> So, Tom, where are we now, from a technical perspective? To the best of
Mark> your knowledge, could we switch to mapped locations now without
Mark> suffering any ill effects?
Yes, there is one ill effect, which is that users will get incorrect
column numbers in error messages.
The simplest way to fix this is to disable column number output
However, it might be worth trying it out and seeing whether the bugs
can be fixed in a timely way. I would recommend that we disable
column output after branching, if the bugs aren't fixed.
I think flipping the default is the best plan (even though, eww, it
makes life hard for the incremental compiler), due to the possibility
of regressions if we don't change it. Plus which, as mentioned
before, it is a win in memory use (though I have not tried to measure
this).
Tom