This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++, diagnostic] PR 33494
- From: Gabriel Dos Reis <gdr at cs dot tamu dot edu>
- To: Paolo Carlini <pcarlini at suse dot de>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: 31 Oct 2007 20:52:08 -0500
- Subject: Re: [C++, diagnostic] PR 33494
- References: <4725C021.7080507@suse.de> <Pine.LNX.4.64.0710290633001.12824@gauss.cs.tamu.edu> <4725CF67.9050908@suse.de>
Paolo Carlini <pcarlini@suse.de> writes:
| Hi Gaby,
| > Hi Paolo, could we just call pp_cxx_expression instead of the split?
| >
| Sure, if we can "export" the entire pp_cxx_expression we can also start
| tidying a bit error.c, I started on that in the below, picking some safe
| recent bits. Tested x86_64-linux. Is it ok?
Hi Paolo,
sorry for the delay.
|
| By the way, in that context, I'm puzzled by the way pp_cxx_expression
| deals with NON_DEPENDENT_EXPR. Is it calling itself or what?
|
| Thanks,
| Paolo.
|
| ///////////////
| /cp
| 2007-10-29 Paolo Carlini <pcarlini@suse.de>
|
| PR c++/33494
| * cxx-pretty-print.c (pp_cxx_expression): Change to extern linkage.
I was meaning to actually call pp_expression(), which indirectly calls
pp_cxx_expression.
| * cxx-pretty-print.h: Adjust declarations.
| * error.c (dump_expr, case EXPR_PACK_EXPANSION, TYPEID_EXPR,
| MEMBER_REF, DOTSTAR_EXPR, DELETE_EXPR, VEC_DELETE_EXPR,
| MODOP_EXPR): Forward to pp_cxx_expression.
This part is OK, if you s/pp_cxx_expression/pp_expression/ and it
passes regression tests.
-- Gaby