This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix PR 31903, type info for types in anonymous namespaces



On 29/10/2007, at 6:25 AM, Richard Guenther wrote:


On 6/14/07, Geoffrey Keating <gkeating@apple.com> wrote:

In the 'else' clause right below the code I remove, there is:


     else if (TREE_CODE (decl) == VAR_DECL && DECL_TINFO_P (decl))
       {
         /* tinfo visibility is based on the type it's for.  */
         constrain_visibility
           (decl, type_visibility (TREE_TYPE (DECL_NAME (decl))));
       }

which is more correct, and in the presence of the code I deleted, is
never used for type info of class types.

Tested with 'make bootstrap', rebuilding libsdc++, and running the C ++
dejagnu testsuite on i386-apple-darwin9.

This causes PR33871 and reverting the change still ends up with the testcase
working. On *-linux-gnu that is. Any idea why?

Darwin and linux are probably different in the paths they take through this code. I commented more in the PR.

Attachment: smime.p7s
Description: S/MIME cryptographic signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]