This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix PR 31903, type info for types in anonymous namespaces


On 10/29/07, Richard Guenther <richard.guenther@gmail.com> wrote:
> On 6/14/07, Geoffrey Keating <gkeating@apple.com> wrote:
> >
> > In the 'else' clause right below the code I remove, there is:
> >
> >       else if (TREE_CODE (decl) == VAR_DECL && DECL_TINFO_P (decl))
> >         {
> >           /* tinfo visibility is based on the type it's for.  */
> >           constrain_visibility
> >             (decl, type_visibility (TREE_TYPE (DECL_NAME (decl))));
> >         }
> >
> > which is more correct, and in the presence of the code I deleted, is
> > never used for type info of class types.
> >
> > Tested with 'make bootstrap', rebuilding libsdc++, and running the C++
> > dejagnu testsuite on i386-apple-darwin9.
>
> This causes PR33871 and reverting the change still ends up with the testcase
> working.  On *-linux-gnu that is.  Any idea why?
>
> Please investigate.

In fact, I think the new testcase should _fail_ now, but the matching
pattern doesn't
fail on

        .file   "anon4.C"
.globl X
        .section        .rodata
        .align 8
        .type   X, @object
        .size   X, 8
X:
        .quad   _ZTIN12_GLOBAL__N_13fooE
        .section        .gnu.linkonce.r._ZTSN12_GLOBAL__N_13fooE,"a",@progbits
        .align 16
        .type   _ZTSN12_GLOBAL__N_13fooE, @object
        .size   _ZTSN12_GLOBAL__N_13fooE, 21
_ZTSN12_GLOBAL__N_13fooE:
        .string "N12_GLOBAL__N_13fooE"
        .section        .rodata
        .align 16
        .type   _ZTIN12_GLOBAL__N_13fooE, @object
        .size   _ZTIN12_GLOBAL__N_13fooE, 16
_ZTIN12_GLOBAL__N_13fooE:
        .quad   _ZTVN10__cxxabiv117__class_type_infoE+16
        .quad   _ZTSN12_GLOBAL__N_13fooE
        .ident  "GCC: (GNU) 4.3.0 20071029 (experimental)"
        .section        .note.GNU-stack,"",@progbits

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]