This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix tree-data-ref.c ICE on VIEW_CONVERT_EXPR<type>(0) (PR tree-optimization/33856)


On 10/27/07, Richard Guenther <richard.guenther@gmail.com> wrote:
> On 10/27/07, Jakub Jelinek <jakub@redhat.com> wrote:
> > Hi!
> >
> > VIEW_CONVERT_EXPR<some_type>(0), while REFERENCE_CLASS_P, doesn't have any
> > base address and is really constant.
> > In get_references_in_stmt any operand which is DECL_P or REFERENCE_CLASS_P
> > is added to the references vector, but later on when for each references
> > vector entry it calls create_data_ref (but in other cases too)
> > get_base_address is called on it and expected to return non-NULL.
> > Either we handle get_base_address returning NULL in dr_analyze_alias
> > and disjoint_objects_p (and additionally need to analyze dr_analyze_indices
> > etc.), or we don't consider a reference to constant as a reference,
> > which is what the attached patch does.
> >
> > Regtested on x86_64-linux, ok for trunk?
>
> Otherwise I guess this is ok.
>

Yes, the fix is ok.

Thanks,
Sebastian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]