This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, tree-optimization]: Fix PR tree-optimization/33920, [4.3 Regression] Segfault in combine_blocks/tree-if-conv.c

From: "Diego Novillo" <dnovillo at google dot com>
To: "Uros Bizjak" <ubizjak at gmail dot com>
Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>
Date: Sun, 28 Oct 2007 08:51:59 -0400
Subject: Re: [PATCH, tree-optimization]: Fix PR tree-optimization/33920, [4.3 Regression] Segfault in combine_blocks/tree-if-conv.c
References: <4723AEC3.4080306@gmail.com> <b798aad50710271747x52e03457ndb824064da976db3@mail.gmail.com> <47246A07.6090109@gmail.com> <47248D65.5050008@gmail.com>

On 10/28/07, Uros Bizjak <ubizjak@gmail.com> wrote:

>         PR tree-optimization/33920
>         * tree-if-conv.c (tree_if_conversion): Force predicate of single
>         successor bb to true when predecessor bb has NULL predicate.

OK.  Please also add a gcc_assert() in
find_phi_replacement_condition() to document that a condition in
bb->aux should always exist.

Diego.

References:
- [PATCH, tree-optimization]: Fix PR tree-optimization/33920, [4.3 Regression] Segfault in combine_blocks/tree-if-conv.c
  - From: Uros Bizjak
- Re: [PATCH, tree-optimization]: Fix PR tree-optimization/33920, [4.3 Regression] Segfault in combine_blocks/tree-if-conv.c
  - From: Diego Novillo
- Re: [PATCH, tree-optimization]: Fix PR tree-optimization/33920, [4.3 Regression] Segfault in combine_blocks/tree-if-conv.c
  - From: Uros Bizjak
- Re: [PATCH, tree-optimization]: Fix PR tree-optimization/33920, [4.3 Regression] Segfault in combine_blocks/tree-if-conv.c
  - From: Uros Bizjak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]