This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR31217 - ICE using FORALL on character substrings

Paul Thomas wrote:
> Regtested on Cygwin_NT/amd64 - will repeat on x86_ia64 just as soon as
> I get home.
> OK for trunk?
I applied the patch plus the addition to "check_forall_dependencies", namely

  if (lsym->ts.type == BT_DERIVED
        && lsym->ts.derived->attr.pointer_comp)
    return need_temp;

which you sent to Dominique to fix the
gfortran.fortran-torture/execute/forall_3.f90 failure.

I bootstrapped and regtested (x86-64/Linux) successfully, built some
packages with the compiler and checked that all test cases of the PRs
are indeed fixed.

Looking at the patch, it think it is OK. (Though, I would not mind if
someone else could glance over the patch as it is rather large.)

Thanks for your tremendous work Paul - and to Dominique for his tests runs.


 dependency.c  |    8 -
 expr.c        |   98 ++++++++++++++++-------
 gfortran.h    |    4
 resolve.c     |  152 +++++++------------------------------
 trans-array.c |    7 +
 trans-stmt.c  |  238 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 6 files changed, 346 insertions(+), 161 deletions(-)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]