This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PING][PATCH] Segfault while unwinding an invalid function pointer

From: "Andrew Pinski" <pinskia at gmail dot com>
To: eberlein at us dot ibm dot com
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 26 Oct 2007 14:14:56 -0700
Subject: Re: [PING][PATCH] Segfault while unwinding an invalid function pointer
References: <470D384A.5060302@linux.vnet.ibm.com> <472257C7.9050608@linux.vnet.ibm.com>

On 10/26/07, Pete Eberlein <eberlein@linux.vnet.ibm.com> wrote:
> This patch, which fixes a segfault problem when generating a backtrace
> from signal handler called as a result of a invalid function pointer
> call, has not yet been reviewed:

I don't like the use of the hard coded /tmp/null here.

And I don't like how on open you abort the program instead of just
doing the same as what happened before.

Also I don't like errno being touched here.

-- Pinski

References:
- [PATCH] Segfault while unwinding an invalid function pointer
  - From: Pete Eberlein
- [PING][PATCH] Segfault while unwinding an invalid function pointer
  - From: Pete Eberlein

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]