This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [doc] cleanups for optimization options in invoke.texi


Hi Janis,

On Thu, 18 Oct 2007, Janis Johnson wrote:
> This patch cleans up several little things for optimization options in
> the GCC Manual.  Tested with make dvi/info/make.  OK for mainline?
> Should I backport it to 4.2, 4.1?

thanks for working on this.  Yes, as far as applicable it definitely
would be good to also backport this set of fixes to the 4.2 branch and
also 4.1 would be desirable.

> 2007-10-18  Janis Johnson  <janis187@us.ibm.com>
> 
> 	* doc/invoke.texi (Optimization Options): In summary, show that
> 	falign-* and -fsched-stalled-insns options take an optional value
> 	and that -ftree-parallelize-loops takes a value; add opindex for
> 	several optimization options; fix types in opindex for several
> 	others; in description for -fsched-stalled-insns, show it with
> 	and without a value.

When it comes to the name of functions in ChangeLog entries, the GNU
Coding Conventions advise not to use wild cards or regular expressions;
I don't think command-line options are explicitly covered, but following
the spirit we probably have to spell those out as well.

Using full stops instead of semicolons will make the changelog easier to
parse, and I believe "type" is a typo for "typo"? ;-)

> --fsched-stalled-insns=@var{n} -fsched-stalled-insns-dep=@var{n} @gol
> +-fsched-stalled-insns[=@var{n}] -fsched-stalled-insns-dep=@var{n} @gol

As far as I can see the parameter is optional also in the case of 
-fsched-stalled-insns-dep?

> -Define how many insns (if any) can be moved prematurely from the queue
> +Define how many insns (if any) can be removed prematurely from the queue
>  of stalled insns into the ready list, during the second scheduling pass.

Would't "moved" be better here than "removed" since the second half of
the sentence says "into the ready list")?  If so, we may want to adjust
this in the following two new sentences added by your patch.

The patch is fine with these changes.

Thanks,
Gerald


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]