This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix ICE in ia64 speculation support


Jim Wilson wrote:
On Mon, 2007-10-15 at 14:16 +0400, Maxim Kuvyrkov wrote:
Jim, sorry I missed to CC you on the original message. Is ia64 part of the patch OK with you?

Yes, it is OK.


You might consider putting the testcase in gcc.target/ia64 since it is
very IA-64 specific.  You won't get multiple runs with different
optimizations here, but I suspect you really only need one run with -O2
or whatever to show the problem.

In the docs, unspec and unspec_volatile should be inside @code{}, and
you shouldn't be using [] to try to abbreviate here.  I'd suggest
something like this:

This target hook returns nonzero if @var{x}, an @code{unspec} or
@code{unspec_volatile} operation, might cause a trap.  Targets can use
this hook to enhance precision of analysis for @code{unspec} and
@code{unspec_volatile} operations.  You may call @code{may_trap_p_1} to
analyze inner elements of @var{x} in which case @var{flags} should be
passed along.

Thanks.


Committed with the above fixes.

--
Maxim


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]