This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[DIAGNOSTICS] (almost trivial) Fix many warning(0) calls


:ADDPATCH diagnostics:

The following patch adds the appropriate OPT_Wxxx flag to a few
warning calls. It also fixes an incorrect? outdated? comment. I have
only updated those cases that were self-evident because they were
already guarded by the corresponding warn_xxx variable. However, this
may not be self-evident in the patch in many cases since the check for
the variable is sometimes quite far away from the call to warning().

The benefit of adding the flag is that 1) It is easier to tell in the
code which warning option generates the warning 2) Users can use
-fdiagnostics-show-options to obtain this information and disable the
warning via -Wno-xxx.

Bootstrapped and regression tested. OK to commit?

Cheers,

Manuel.


2007-10-16  Manuel López-Ibáñez  <manu@gcc.gnu.org>

  * builtins.c (gimplify_va_arg_expr): Use inform for help message.
  * toplev.c (check_global_declaration_1): Use appropriate warning
option instead of unnamed warning.
  * stor-layout.c (layout_decl): Likewise.
  * c-typeck.c (build_conditional_expr): Likewise.
  (build_compound_expr): Fix wrong comment.
  (build_binary_op): Use appropriate warning option instead of unnamed warning.
  * cfgexpand.c (tree_expand_cfg): Likewise.
  * tree-optimize.c (tree_rest_of_compilation): Likewise.
  * tree-cfg.c (remove_useless_stmts_warn_notreached): Likewise.
  (execute_warn_function_return): Likewise.
  * stmt.c (warn_if_unused_value): Likewise.

cp/
 * typeck.c (build_binary_op) : Use appropriate warning option instead
of unnamed warning.

Attachment: warning0.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]