This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ICE in ia64 speculation support
- From: Jim Wilson <wilson at specifix dot com>
- To: Maxim Kuvyrkov <maxim at codesourcery dot com>
- Cc: Eric Botcazou <ebotcazou at libertysurf dot fr>, bonzini at gnu dot org, Vladimir Makarov <vmakarov at redhat dot com>, Andrey Belevantsev <abel at ispras dot ru>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 15 Oct 2007 14:39:42 -0700
- Subject: Re: [PATCH] Fix ICE in ia64 speculation support
- References: <46E97245.5010107@codesourcery.com> <46F38C66.7070800@lu.unisi.ch> <471244AE.60300@codesourcery.com> <200710151008.16369.ebotcazou@libertysurf.fr> <47133DFB.9010308@codesourcery.com>
On Mon, 2007-10-15 at 14:16 +0400, Maxim Kuvyrkov wrote:
> Jim, sorry I missed to CC you on the original message. Is ia64 part of
> the patch OK with you?
Yes, it is OK.
You might consider putting the testcase in gcc.target/ia64 since it is
very IA-64 specific. You won't get multiple runs with different
optimizations here, but I suspect you really only need one run with -O2
or whatever to show the problem.
In the docs, unspec and unspec_volatile should be inside @code{}, and
you shouldn't be using [] to try to abbreviate here. I'd suggest
something like this:
This target hook returns nonzero if @var{x}, an @code{unspec} or
@code{unspec_volatile} operation, might cause a trap. Targets can use
this hook to enhance precision of analysis for @code{unspec} and
@code{unspec_volatile} operations. You may call @code{may_trap_p_1} to
analyze inner elements of @var{x} in which case @var{flags} should be
passed along.
--
Jim Wilson, GNU Tools Support, http://www.specifix.com