This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, rtl-optimization]: Fix PR rtl-optimization/33638
> Are you sure that checking stack_pointer_rtx is enough here? Note
> that DSE is run after reload. I would think that in some cases dse
> might see hard_frame_pointer_rtx.
For stores related to outgoing arguments? If so, no, this is not enough.
> Otherwise, this looks good to me. Please commit it if it passes testing.
It passed testing and I committed it yesterday.
> Your patch is conservative, in that it assumes that a const call may
> use any store to the stack frame. The use I see for
> CALL_INSN_FUNCTION_USAGE would be to make this less conservative, in
> that it would then be possible to prove that some stores to the stack
> frame are not used by the const call. Is that what you mean?
I was thinking from a more general point of view. Theoritically nothing would
prevent CALL_INSN_FUNCTION_USAGE from containing "unexpected" uses.