This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] restore NOSTRIP for .debug_frame on mips-irix


Olivier Hainque <hainque@adacore.com> writes:
> Hello Richard,
>
> Richard Sandiford wrote:
>> If we need this bit set for correctness, I think GAS should add it
>> automatically when the GAS (rather than IRIX) .section syntax is
>> used.
>
>  The patch was simply modeled after what the compiler used to do.
>  I agree that dealing with this in GAS looks cleaner.
>
>> GAS already knows that certain sections are special in certain ways,
>
>  Indeed.
>
>> and if proper behaviour requires a GAS change too, I
>> suppose users will have to upgrade to newer binutils either way.
>
>  Actually, we had observed the behavior with 2.16, this led to a
>  discussion with a patch suggestion at
>
>     http://www.cygwin.com/ml/binutils/2005-02/msg00688.html
>
>  The patch was approved but apparently didn't go in and I was
>  assuming it was still needed.
>
>  However, I just tried my patched compiler with untouched 2.17 and
>  2.18 assemblers and both seem to propagate the extra NOSTRIP bit, so
>  something else happened.

Ah, interesting.  I _very_ vaguely remember other patches related
to MIPS section flags, so perhaps one of those fixed it.  That's
not much help, sorry...

>  Anyway, _bfd_mips_elf_fake_sections in bfd/elfxx-mips.c still really
>  looks like the proper place to have this change as there is a lot of
>  similar processing there already.
>
>  The attached patch fixes the tiny case I posted, and I'd be happy to
>  submit it to the binutils list after the required testing if you think
>  is appropriate.

Thanks for the patch.  FWIW, it looks good to me, although I can't
approve it.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]