This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: enumerate explicitly what is enabled by Wall
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: Gerald Pfeifer <gerald at pfeifer dot com>, Diego Novillo <dnovillo at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 09 Oct 2007 12:35:44 -0700
- Subject: Re: enumerate explicitly what is enabled by Wall
- References: <6c33472e0709230643qdf898c9l367bcee38637d897@mail.gmail.com> <6c33472e0709291226v58579dc4m21fcab4a23c2af3c@mail.gmail.com> <b798aad50709291555t4adcc0bald1fca8628b556dc3@mail.gmail.com> <Pine.LNX.4.64.0709301521350.26054@acrux.dbai.tuwien.ac.at> <6c33472e0709301138h50411d71wd873e0e88708a41d@mail.gmail.com> <Pine.LNX.4.64.0710080210520.26054@acrux.dbai.tuwien.ac.at> <470AAF21.8070808@codesourcery.com> <6c33472e0710090838j8ccece8k40913dd21365f651@mail.gmail.com>
Manuel López-Ibáñez wrote:
> On 08/10/2007, Mark Mitchell <mark@codesourcery.com> wrote:
>> Gerald Pfeifer wrote:
>>
>>>> 2007-09-30 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
>>>>
>>>> * c-opts.c(c_common_handle_option): -Wnontemplate-friend,
>>>> -Wwrite-strings and -Wmultichar are enabled by default, so Wall
>>>> enabling them is redundant. Don't check two times for c_dialect_cxx.
>>> This looks more like a bug fix, really. Mark?
>> Please send me a URL for the full patch, and I shall review.
>>
>
> The patch is inlined here:
> http://gcc.gnu.org/ml/gcc-patches/2007-09/msg02104.html
This patch is OK.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713