This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] Fix PR 33683, wrong gamma function


Tobias Schlüter wrote:
Thomas Koenig wrote:
this fixes PR 33683 on the sytems (such as libc systems) where gamma()
actually returns the logarithm of the gamma function.

The test case risks failure on systems where there is no tgamma()
function.  We probably need a separate tgamma function for
these systems.  The current patch is an improvement over the old status,
where we would return (horribly) wrong values silently.

Regression-tested on i686-pc-linux-gnu, where we used to return the
wrong values. OK for trunk?

Yes, definitely. I think it would be a good thing to remove the gamma builtin from the middle-end, if it's not guaranteed to return the same value across platforms, but that's probably someone else's job.


Cheers,
- Tobi

Yes, commit now so that we can identify the other platforms that do not have tgamma, then deal with those.

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]