This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, fortran] PR33542 - gfortran does not detect ambigious specific names if they are the same as generic names

From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
To: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Sun, 07 Oct 2007 21:21:00 +0200
Subject: Re: [Patch, fortran] PR33542 - gfortran does not detect ambigious specific names if they are the same as generic names
References: <339c37f20710071201p594ed61ex33a4337e2d164ee6@mail.gmail.com>

Paul Richard Thomas wrote:

+       if (e->expr_type == FL_VARIABLE && e->symtree->ambiguous)
+ 	{
+ 	  gfc_error ("'%s' at %L is ambiguous", e->symtree->n.sym->name,
+ 		     &e->where);
+ 	  return FAILURE;
+ 	}

I forgot how we handle renames (I mean USE X, A=>B), but I'm guessing that e->symtree->name would be the safe choice for the name to print. Also a testcase with renaming would be a good thing to have.

Unless there is trouble with renaming, the patch is ok.

Cheers,
- Tobi

Follow-Ups:
- Re: [Patch, fortran] PR33542 - gfortran does not detect ambigious specific names if they are the same as generic names
  - From: Paul Richard Thomas

References:
- [Patch, fortran] PR33542 - gfortran does not detect ambigious specific names if they are the same as generic names
  - From: Paul Richard Thomas

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]