This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PR 33653: don't optimize volatile mem accesses


> dce.c and dse.c use the wrong predicates to check if an insn is
> undeletable because of volatile accesses.  They use volatile_insn_p(),
> whereas they should use volatile_refs_p() (like the old flow code did).
>
> I've started testing.  Okay for trunk?

Obvious I'd think, but nevertheless OK. :-)

> Is it possible in our testsuite to check that RTL doesn't optimize away
> the volatile read?

By testing that we have a non-null frame at -O or above?

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]