This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Fortran, Patch, OpenMP] PR33445 - Warn if (free format) !$OMP& is used as no continuation line
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: Jakub Jelinek <jakub at redhat dot com>, "'fortran at gcc dot gnu dot org'" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 21 Sep 2007 09:03:46 -0700
- Subject: Re: [Fortran, Patch, OpenMP] PR33445 - Warn if (free format) !$OMP& is used as no continuation line
- References: <46F3E48C.3090206@net-b.de>
On Fri, Sep 21, 2007 at 05:34:36PM +0200, Tobias Burnus wrote:
> :ADDPATCH fortran:
>
> 2007-09-21 Tobias Burnus <burnus@net-b.de>
>
> PR fortran/33445
> * scanner.c (skip_free_comments): Warn if !$OMP& is used
> if no OpenMP directive is to be continued.
>
> 2007-09-21 Tobias Burnus <burnus@net-b.de>
>
> PR fortran/33445
> * gfortran.dg/gomp/free-2.f90: New.
> * gfortran.dg/gomp/appendix-a/a.31.1.f90: Add missing &.
I'll let FX or Jakub give the final approval. Just a comment
below.
> + else if (c2 == '&')
> + gfc_warning_now ("Found $!OMP& at %C but no "
> + "preceeding directive with "
> + "a tailing &");
s/preceeding/preceding
s/tailing/trailing
> +!
> +!$OMP&foo ! { dg-warning "no preceeding directive" }
> +!$OMP parallel
> +!$OMP& default(shared) ! { dg-warning "no preceeding directive" }
s/preceeding/preceding
--
Steve