This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Support printing inlining call stack in diagnostic messages (take 2)


On 11/09/2007, Jakub Jelinek <jakub@redhat.com> wrote:
>
> For some reason g++.dg/ testsuite harness doesn't grok dg-message
> (while gcc.dg/ does), but at least for now dg-warning instead
> works as well even when it is a note.

This is because nobody has fixed PR25241 for C++ front-end yet. It is
only fixed for C front-end. Porting dg-message may be easy and won't
require to fix all the testsuite failures.

Your approach just workarounds the problem in the wrong way and will
make harder to fix it in the future. If you don't wish to implement
dg-message for C++ testsuite, please use:

dg-warning "note: whatever"

that way, fixing the testsuite will be easier when the right person comes.

Thanks,

Manuel.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]