This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Clean up df in case of reload failure (PR middle-end/32370)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 26 Aug 2007 17:02:16 -0400
- Subject: Re: [PATCH] Clean up df in case of reload failure (PR middle-end/32370)
- References: <20070824202241.GI2063@devserv.devel.redhat.com> <46CFBF81.5030604@gnu.org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sat, Aug 25, 2007 at 07:34:57AM +0200, Paolo Bonzini wrote:
>
> >df-core.c requires its passes (rest_of_handle_df_initialize
> >and rest_of_handle_df_finish) to be executed in pairs, if
> >it is initialized, it must be cleaned up and it can't be cleaned up
> >if not initialized. But they are invoked in different passes.c
> >pass lists.
>
> I assume you tested moving pass_df_finish out of pass_postreload. If
> so, this patch is ok.
That worked too, at least on x86_64-linux. But is that the right thing to
do? There is some cost associated with keeping df up to date through the
remaining passes, and if nothing needs the df info in those passes...
Jakub