[hjl@lucon.org: Re: [Fwd: Failure in bootstrapping GFortran 4.3.0 on Cygwin]]

["H.J. Lu" <hjl at lucon dot org>]

----- Forwarded message from "H.J. Lu" <hjl@lucon.org> -----

Date: Fri, 17 Aug 2007 06:04:29 -0700
From: "H.J. Lu" <hjl@lucon.org>
To: Paolo Carlini <pcarlini@suse.de>
Subject: Re: [Fwd: Failure in bootstrapping GFortran 4.3.0 on Cygwin]
User-Agent: Mutt/1.5.14 (2007-02-12)

On Fri, Aug 17, 2007 at 01:18:36PM +0200, Paolo Carlini wrote:
> HJ,
> 
> please fix!
> 
> Thanks,
> Paolo.
> 
> 
> -------- Original Message --------
> Subject: 	Failure in bootstrapping GFortran 4.3.0 on Cygwin
> Date: 	Fri, 17 Aug 2007 08:55:38 +0200
> From: 	Angelo Graziosi <Angelo.Graziosi@roma1.infn.it>
> To: 	fortran@gcc.gnu.org
> CC: 	gcc@gcc.gnu.org
> 
> 
> 
> I want to flag that some changes in GCC 4.3.0 20070816 rev 127568:
> 
>        * Makefile.in (REVISION): New.
>        (REVISION_c): New.
>        (REVISION_s): New.
>        (version.o): Also depend on $(REVISION). Add
>        -DREVISION=$(REVISION_s).
> 
>        * version.c (version_string): Add REVISION.
> 
> causes failure on Cygwin:
> 
> 
> gcc -c   -g -fkeep-inline-functions -DIN_GCC   -W -Wall -Wwrite-strings
> -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition
> -Wmissing-format-attribute    -DHAVE_CONFIG_H -I. -I. -I/tmp/gcc/gcc
> -I/tmp/gcc/gcc/. -I/tmp/gcc/gcc/../include
> -I/tmp/gcc/gcc/../libcpp/include  -I/tmp/gcc/gcc/../libdecnumber
> -I/tmp/gcc/gcc/../libdecnumber/bid -I../libdecnumber
> /tmp/gcc/gcc/varray.c -o varray.o
> gcc -c   -g -fkeep-inline-functions -DIN_GCC   -W -Wall -Wwrite-strings
> -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition
> -Wmissing-format-attribute    -DHAVE_CONFIG_H -I. -I. -I/tmp/gcc/gcc
> -I/tmp/gcc/gcc/. -I/tmp/gcc/gcc/../include
> -I/tmp/gcc/gcc/../libcpp/include  -I/tmp/gcc/gcc/../libdecnumber
> -I/tmp/gcc/gcc/../libdecnumber/bid -I../libdecnumber    /tmp/gcc/gcc/vec.c
> -o vec.o
> make[3]: *** No rule to make target /tmp/gcc/gcc/REVISION', needed by
> version.o'.  Stop.
> make[3]: Leaving directory /tmp/gcc/build/gcc'
> make[2]: *** [all-stage1-gcc] Error 2
> make[2]: Leaving directory /tmp/gcc/build'
> make[1]: *** [stage1-bubble] Error 2
> make[1]: Leaving directory /tmp/gcc/build'
> make: *** [all] Error 2
> 
> 
> Cheers,
> 
>  Angelo.
> 

I am checking in this patch to fix it.

Thanks.


H.J.
----
2007-08-17  H.J. Lu  <hongjiu.lu@intel.com>

	* Makefile.in (version.o): Depend on $(REVISION) only if
	REVISION_s is defined.

--- Makefile.in.foo	2007-08-17 05:43:14.000000000 -0700
+++ Makefile.in	2007-08-17 05:58:42.000000000 -0700
@@ -1920,7 +1920,11 @@ gcc-options.o: options.c $(CONFIG_H) $(S
 
 dumpvers: dumpvers.c
 
+ifdef REVISION_s
 version.o: version.c version.h $(REVISION) $(DATESTAMP) $(BASEVER) $(DEVPHASE)
+else
+version.o: version.c version.h $(DATESTAMP) $(BASEVER) $(DEVPHASE)
+endif
 	$(CC) $(ALL_CFLAGS) $(ALL_CPPFLAGS) \
 	-DBASEVER=$(BASEVER_s) -DDATESTAMP=$(DATESTAMP_s) \
 	-DREVISION=$(REVISION_s) \

----- End forwarded message -----