This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR33072 - Reject "use mod, only: operator(.foo.)" where "foo" is no operator


Tobias,
:ADDPATCH fortran:

gfortran did not check whether operator(.symbol.) in USE statements were
really (user) operators or other symbols such as functions or
subroutines. This patch adds such a check.

Regression tested on x86-64/Linux. Ok for the Trunk?
Would a static flag, rather than an extra argument, not look cleaner?

Whatever you decide, OK for trunk.

Thanks

Paul
<-----------Side note------------>
Unfortunately, this patch does not bring PR31298 any closer to being
fixed :-(
I'm not surprised!
The problem is that I still don't fully understand how operators are
imported in modules.
Failing is currently:
- Multiple imports of operator(.useroperator.), example: see PR33072;
one needs to
do the same in load_operator_interfaces as in load_generic_interfaces,
but I don't
know how to handle the "i > 1" case.
Can you not do exactly the same? I confess that I have not looked at it but the generic interfaces mechanism copied over directly from that to handle symbols.
- Renames of the kind "operator(+) => operator(.myplus.)"

<------End of Side note--------->

Tobias
------------------------------------------------------------------------


2007-08-16 Tobias Burnus <burnus@net-b.de>

	PR fortran/33072
	* module.c (gfc_match_use): Mark user operators as such.
	(find_use_name_n): Distinguish between operators and other symbols.
	(find_use_name,number_use_names,mio_namelist,
	 load_operator_interfaces,load_generic_interfaces,read_module,
	 write_generic): Update find_use_name_n calls.

2007-08-16 Tobias Burnus <burnus@net-b.de>

	PR fortran/33072
	* gfortran.dg/use_9.f90: New.

Index: gcc/fortran/module.c
===================================================================
--- gcc/fortran/module.c (revision 127532)
+++ gcc/fortran/module.c (working copy)
@@ -612,6 +612,9 @@ gfc_match_use (void)
== FAILURE))
goto cleanup;
+ if (type == INTERFACE_USER_OP)
+ new->operator = INTRINSIC_USER;
+
if (only_flag)
{
if (m != MATCH_YES)
@@ -677,10 +680,12 @@ cleanup:
/* Given a name and a number, inst, return the inst name
under which to load this symbol. Returns NULL if this
symbol shouldn't be loaded. If inst is zero, returns
- the number of instances of this name. */
+ the number of instances of this name. If interface is
+ true, a user-defined operator is sought, otherwise only
+ non-operators are sought. */
static const char *
-find_use_name_n (const char *name, int *inst)
+find_use_name_n (const char *name, int *inst, bool interface)
{
gfc_use_rename *u;
int i;
@@ -688,7 +693,9 @@ find_use_name_n (const char *name, int *
i = 0;
for (u = gfc_rename_list; u; u = u->next)
{
- if (strcmp (u->use_name, name) != 0)
+ if (strcmp (u->use_name, name) != 0
+ || (u->operator == INTRINSIC_USER && !interface)
+ || (u->operator != INTRINSIC_USER && interface))
continue;
if (++i == *inst)
break;
@@ -713,21 +720,21 @@ find_use_name_n (const char *name, int *
Returns NULL if this symbol shouldn't be loaded. */
static const char *
-find_use_name (const char *name)
+find_use_name (const char *name, bool interface)
{
int i = 1;
- return find_use_name_n (name, &i);
+ return find_use_name_n (name, &i, interface);
}
/* Given a real name, return the number of use names associated with it. */
static int
-number_use_names (const char *name)
+number_use_names (const char *name, bool interface)
{
int i = 0;
const char *c;
- c = find_use_name_n (name, &i);
+ c = find_use_name_n (name, &i, interface);
return i;
}
@@ -2869,7 +2876,7 @@ mio_namelist (gfc_symbol *sym)
conditionally? */
if (sym->attr.flavor == FL_NAMELIST)
{
- check_name = find_use_name (sym->name);
+ check_name = find_use_name (sym->name, false);
if (check_name && strcmp (check_name, sym->name) != 0)
gfc_error ("Namelist %s cannot be renamed by USE "
"association to %s", sym->name, check_name);
@@ -3131,7 +3138,7 @@ load_operator_interfaces (void)
mio_internal_string (module);
/* Decide if we need to load this one or not. */
- p = find_use_name (name);
+ p = find_use_name (name, true);
if (p == NULL)
{
while (parse_atom () != ATOM_RPAREN);
@@ -3168,18 +3175,18 @@ load_generic_interfaces (void)
mio_internal_string (name);
mio_internal_string (module);
- n = number_use_names (name);
+ n = number_use_names (name, false);
n = n ? n : 1;
for (i = 1; i <= n; i++)
{
/* Decide if we need to load this one or not. */
- p = find_use_name_n (name, &i);
+ p = find_use_name_n (name, &i, false);
if (p == NULL || gfc_find_symbol (p, NULL, 0, &sym))
{
while (parse_atom () != ATOM_RPAREN);
- continue;
+ continue;
}
if (sym == NULL)
@@ -3548,14 +3555,14 @@ read_module (void)
/* See how many use names there are. If none, go through the start
of the loop at least once. */
- nuse = number_use_names (name);
+ nuse = number_use_names (name, false);
if (nuse == 0)
nuse = 1;
for (j = 1; j <= nuse; j++)
{
/* Get the jth local name for this symbol. */
- p = find_use_name_n (name, &j);
+ p = find_use_name_n (name, &j, false);
if (p == NULL && strcmp (name, module_name) == 0)
p = name;
@@ -3958,7 +3965,7 @@ write_generic (gfc_symbol *sym)
sym->module = gfc_get_string (module_name);
/* See how many use names there are. If none, use the symbol name. */
- nuse = number_use_names (sym->name);
+ nuse = number_use_names (sym->name, false);
if (nuse == 0)
{
mio_symbol_interface (&sym->name, &sym->module, &sym->generic);
@@ -3968,7 +3975,7 @@ write_generic (gfc_symbol *sym)
for (j = 1; j <= nuse; j++)
{
/* Get the jth local name for this symbol. */
- p = find_use_name_n (sym->name, &j);
+ p = find_use_name_n (sym->name, &j, false);
mio_symbol_interface (&p, &sym->module, &sym->generic);
}
Index: gcc/testsuite/gfortran.dg/use_9.f90
===================================================================
--- gcc/testsuite/gfortran.dg/use_9.f90 (revision 0)
+++ gcc/testsuite/gfortran.dg/use_9.f90 (revision 0)
@@ -0,0 +1,15 @@
+! { dg-do compile }
+module test
+ interface operator(.bar.)
+ module procedure func
+ end interface
+contains
+function func(a)
+ integer,intent(in) :: a
+ integer :: funct
+ func = a+1
+end function
+end module test
+
+use test, only: operator(.func.) ! { dg-error "not found in module 'test'" }
+end



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]