This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
David,
While integrating into 4.1.2 I had a brief look over your patch again over the weekend and I have got two minor points:
1. You use "unsigned" rather than "unsigned int", which makes your code look a little bit too K&Rish.
2. Given the coverage FFI_MIPS_N32 should probably be renamed to FFI_MIPS_NEWABI as it is now somewhat confusing.
And last but not least, with your changes there is now no difference between Linux and IRIX anymore, so it may be worth unifying the MIPS target like the others; it seems to be the only oddball.
2007-08-13 Maciej W. Rozycki <macro@linux-mips.org>
* Makefile.am: Unify MIPS_IRIX and MIPS_LINUX into MIPS. * configure.ac: Likewise. * Makefile.in: Regenerate. * configure: Regenerate.
OK to apply?
Thanks, David Daney
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |