This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] libffi testsuite: Correct some type specifiers.
- From: Tom Tromey <tromey at redhat dot com>
- To: David Daney <ddaney at avtrex dot com>
- Cc: GCJ-patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, andreast at gcc dot gnu dot org
- Date: Tue, 07 Aug 2007 10:46:34 -0600
- Subject: Re: [Patch] libffi testsuite: Correct some type specifiers.
- References: <46B89D13.50708@avtrex.com>
- Reply-to: tromey at redhat dot com
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> Whilst hacking things up to get MIPS64 working better in libffi, I
David> came across several test cases where structure elements were declared
David> as type 'int' but the libffi type specifier identified them as uint32.
David> This patch corrects some (but probably not all) of these incongruities.
I think a patch to fix a disparity like this would qualify as obvious.
However... if the struct definition says 'int', and the test case is
says ffi_type_sint32, then that seems like a bug in itself. There's
no guarantee that int == 32 bits. Wouldn't it be more correct to use
ffi_type_sint?
Tom