This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] middle end, s390: optimization for builtin isnan


Wolfgang Gellerich<gellerich@de.ibm.com> writes:

> This patch introduces a new target hook allowing to optimize the
> implementation of builtin function isnan on platforms like s390 where
> arithmetic operations set the condition code when the result was NaN.  It
> bootstraps on Intel and s390 and does not introduce new test case failures.

It seems to me that we should handle this by treating isnan as a unary
operator which may be implemented in the MD file.  E.g., implement
isnansf1 and isnandf1, with optabs.  I don't see why a target hook is
the right thing here.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]