This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH PING: distcc and ccache speedup: adds directives-only preprocessing

On Wed, Jul 25, 2007 at 09:00:54AM -0700, Ian Lance Taylor wrote:
> This is the patch to speed up the preprocessor that I mentioned at the
> summit.  I've reviewed the patch a few times now, and it looks good to
> me.  It has been in active use at Google for every compilation for
> about six months with no problems.
> I would approve the patch if I could, but, unfortunately, since it
> adds a new option and a new way of reading files, it is probably
> non-algorithmic.  That means that I can't approve it, nor can Tom.  We
> need an approval from a global write maintainer, or from a C or C++
> front-end maintainer.
> Can somebody take a look?  Thanks.
> Ian

Sorry this got routed to my old email that mostly gathers spam, and I didn't
notice it at first.  Some comments:

1) On line 123 of directives-c.c in function _cpp_handle_directive, there is a
   '\' at the end of a line, but since it isn't inside of a macro, you really
   don't need it.

2) In line 179 of c-ppoutput.c in function print_lines_directives_only, I
   noticed there is a fwrite without checking to see if it succeeded or not.
   However, since scan_translation_unit_trad also does this, so it isn't any
   different from the current code.

3) I'm not up on the .texi style guidelines, but you might want to quote distcc
   with something like @samp{distcc}.

Other that, it looks good.

Michael Meissner, AMD
90 Central Street, MS 83-29, Boxborough, MA, 01719, USA

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]