This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: Re: patch: libiberty adjustments for _WIN64


DJ Delorie <dj@redhat.com> writes:

> > This code all seems like a complex workaround for the fact that
> > pex-common.h uses "long" as the return type for the exec_child hook.
> > But pex-common.c really doesn't care what the value is.  It just
> > takes the value from the exec_child hook and passes it to the wait
> > hook.  So rather than introducing a new array in the heap, let's
> > just change the interface.
> 
> We've had this discussion before; the problem is that some platforms
> have sizeof(long) > sizeof(void*) and others have sizeof(long) <
> sizeof(void*).  So you can't just pass "anything" through that API
> unless you have configure pick a suitable type and build libiberty
> with it as well as your application.

As far as I can see, the type used here is never exposed outside of
the pex_run interface.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]