This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,testsuite] fix gcc.dg/tree-ssa/wholeprogram-1.c for -fPIC
- From: "Kaveh R. GHAZI" <ghazi at caip dot rutgers dot edu>
- To: Nathan Froyd <froydnj at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 25 Jul 2007 14:09:13 -0400 (EDT)
- Subject: Re: [PATCH,testsuite] fix gcc.dg/tree-ssa/wholeprogram-1.c for -fPIC
- References: <20070725172953.GA13536@sparrowhawk.codesourcery.com>
On Wed, 25 Jul 2007, Nathan Froyd wrote:
> The attached patch resolves a problem with
> gcc.dg/tree-ssa/wholeprogram-1.c and testing with -fPIC. With -fPIC,
> the inliner believes that large_function is not eligible for inlining
> because global symbols can be overridden from other modules, which
> causes the testcase to fail. The simplest solution is to mark
> large_function as static, thereby ensuring that large_function is a
> local symbol rather than a global one.
>
> Tested on powerpc-wrs-vxworks with and without -fPIC. No regressions.
> OK to commit?
>
> -Nathan
>
> 2007-07-25 Nathan Froyd <froydnj@codesourcery.com>
>
> gcc/testsuite/
> * gcc.dg/tree-ssa/wholeprogram-1.c (large_function): Declare as
> static to ensure it gets inlined even when -fPIC.
This is PR25445. Can you address Andrew's comment in the PR? He seem to
say that this is a compiler bug, not a testsuite bug.
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu