This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add GIMPLE type verifier enabled for stage1
- From: Diego Novillo <dnovillo at google dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 25 Jul 2007 12:18:43 -0400
- Subject: Re: [PATCH] Add GIMPLE type verifier enabled for stage1
- References: <Pine.LNX.4.64.0707251801250.10096@zhemvz.fhfr.qr>
On 7/25/07 12:04 PM, Richard Guenther wrote:
> toplev/
> * configure.ac: Add types checking to stage1 checking flags.
> * configure: Regenerate.
>
> * tree-cfg.c (verify_gimple_unary_expr, verify_gimple_binary_expr,
> verify_gimple_min_lval, verify_gimple_reference, verify_gimple_expr,
> verify_gimple_modify_stmt, verify_gimple_stmt, verify_gimple_1,
> verify_gimple): New functions.
> * tree-flow.h (verify_gimple): Declare.
> (verify_gimple_1): Declare.
> * gimplify.c (cpt_same_type): Remove.
> (gimplify_addr_expr): Remove checking code.
> (check_pointer_types_r): Remove.
> (gimplify_body): Call verify_gimple_1 instead of check_pointer_types_r.
> Only verify if there were no errors.
> * configure.ac: Add types checking flag.
> * configure: Regenerate.
> * config.in: Regenerate.
Good stuff. OK with:
> + case CALL_EXPR:
> + /* FIXME. This is going to be difficult with non-unit-at-a-time
> + gimplifying. */
> + return false;
Why? The comment is not too clear.
> + return false;
> + /*return verify_gimple_expr (rhs) || verify_gimple_expr (lhs);*/
> + }
Remove the commented code. Or at most add a FIXME note stating why we
can't do the recursion.