This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Reduce startup cost of compiler (patch 3)


On 7/24/07 1:05 AM, Jan Hubicka wrote:

> 	* caller-save.c: Include ggc.h, gt-caller-save.h
> 	(reg_save_code, reg_restore_code): Rename to ...
> 	(cached_reg_save_code, cached_reg_restore_code): ... those.
> 	(savepat, restpat, test_reg, test_mem, saveinsn, restinsn): New.
> 	(reg_save_code, reg_restore_code): New functions.
> 	(init_caller_save): Do not intialize
> 	reg_save_code/reg_restore_code tables.
> 	* Makeifle.in: (gt-caller-save.h): New.

OK with:

> + static int
> + reg_save_code (int reg, enum machine_mode mode)

Missing documentation.

> + static int
> + reg_restore_code (int reg, enum machine_mode mode)
> + {

Likewise.

> +   if (cached_reg_restore_code[reg][mode])
> +      return cached_reg_restore_code[reg][mode];
> +   /* polute our cache.  */

s/polute/pollute/

> --- 704,710 ----
>     pat = gen_rtx_SET (VOIDmode,
>   		     gen_rtx_REG (GET_MODE (mem),
>   				  regno), mem);
> !   code = reg_restore_code(regno, GET_MODE (mem));

Space before '('.

> --- 776,782 ----
>     pat = gen_rtx_SET (VOIDmode, mem,
>   		     gen_rtx_REG (GET_MODE (mem),
>   				  regno));
> !   code = reg_save_code(regno, GET_MODE (mem));

Likewise.

> @@ -2700,7 +2700,8 @@ postreload-gcse.o : postreload-gcse.c $(
>     $(PARAMS_H) $(TIMEVAR_H) tree-pass.h $(REAL_H) $(DBGCNT_H)
>  caller-save.o : caller-save.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) \
>     $(FLAGS_H) $(REGS_H) hard-reg-set.h insn-config.h $(BASIC_BLOCK_H) $(FUNCTION_H) \
> -   addresses.h $(RECOG_H) reload.h $(EXPR_H) toplev.h $(TM_P_H) $(DF_H)
> +   addresses.h $(RECOG_H) reload.h $(EXPR_H) toplev.h $(TM_P_H) $(DF_H) \
> +   gt-caller-save.h

ggc.h should also be included here.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]