This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Fix g++.dg/opt/pr24665.C
On 7/20/07, Hans-Peter Nilsson <hp@bitrange.com> wrote:
On Wed, 18 Jul 2007, Daniel Berlin wrote:
> This fixes the regression caused by sccvn where pr24665.C now
> propagates an invalid gimple expression around from DECL_INITIAL.
>
>
> Bootstrapped and regtested on i686-darwin.
>
> Okay for mainline?
> 2007-07-18 Daniel Berlin <dberlin@dberlin.org>
>
> * tree-ssa-sccvn.c (try_to_simplify): Use valid_gimple_expression
> * tree-ssa-propagate (valid_gimple_expression): Handle ADDR_EXPR
> properly.
I'm sorry, but this didn't fix the problem for me for x to
cris-elf. I still see as I mentioned
Grrr, i have an additional fix in that tree that was not committed,
that seems to be what really fixed this.
Please try:
Index: tree-ssa-propagate.c
===================================================================
--- tree-ssa-propagate.c (revision 126804)
+++ tree-ssa-propagate.c (working copy)
@@ -617,7 +617,7 @@ valid_gimple_expression_p (tree expr)
return false;
t = TREE_OPERAND (t, 0);
}
- if (!is_gimple_addressable (t))
+ if (!is_gimple_id (t))
return false;
break;
}