This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p


REGNO sorting is impossible to do in swap_commutative_operands_p. It is pretty normal for simplify-rtx.c (and also the simplification routines in combine.c) to enforce additional canonicalization than the one in swap_commutative_operands_p. 

So you're recommending removing the part of the patch that does REGNO
sorting from swap_commutative_operands_p now?  Meaning no longer trying
to make is similar to simplify_plus_minus_op_data_cmp.

Yes, if it fixes the 387 bug and it is not necessary to achieve the good performance on POWER6, I don't see a problem in omitting that hunk.

Paolo

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]