This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: libiberty adjustments for _WIN64


Hi Jakub,

> This is obviously wrong.  As xmalloc never returns NULL, pid_map
> will be always non-NULL and the memcpy call will be always invalid,
> as nh == pid_map and memcpy regions can't overlap.  And it won't do
> what you want to do.
> Guess you should use xrealloc instead of xmalloc,
> and only set to -1 the last 8 entries in the array.

Ups... This was obvious wrong. I corrected it in the patch attached. Sorry 
8)
"xrealloc" would be possible for reallocating the memory block, but I want 
to ensure that the the new memory block elements are set to -1.

Cheers,
 i.A. Kai Tietz


|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer: 
Ulrike DÃhler, Manuela Kluger

Attachment: iberty_win64.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]