This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p

From: Paolo Bonzini <bonzini at gnu dot org>
To: "H.J. Lu" <hjl at lucon dot org>
Cc: Jakub Jelinek <jakub at redhat dot com>, Peter Bergner <bergner at vnet dot ibm dot com>, Pat Haugen <pthaugen at us dot ibm dot com>, Dave Korn <dave dot korn at artimi dot com>, gcc-patches at gcc dot gnu dot org, Ian Lance Taylor <iant at google dot com>, Rask Ingemann Lambertsen <rask at sygehus dot dk>, Richard Guenther <richard dot guenther at gmail dot com>, michael dot meissner at amd dot com
Date: Fri, 13 Jul 2007 23:43:22 +0200
Subject: Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
References: <20070626230126.GA14180@lucon.org> <OFCCCEC8E3.B30CC185-ON86257315.006E3FA2-86257315.006FC7FB@us.ibm.com> <20070711223208.GA31985@lucon.org> <1184203327.7983.60.camel@otta> <46971979.1080104@lu.unisi.ch> <1184348142.8319.75.camel@otta> <20070713184737.GA32407@lucon.org> <4697D3B1.3040304@lu.unisi.ch> <20070713194935.GA32665@lucon.org> <20070713195833.GN2063@devserv.devel.redhat.com> <20070713201841.GA379@lucon.org>

I don't know even know which changes should be guarded by a target
macro since there are quite a few independent changes in that
patch.

Two hunks are bugfixes. The other two (in rtlanal.c) are the only targets that could affect performance but, again, it's just luck or bad luck.

I don't see the addressing modes in x86 that well tuned. Surely not the tuning that Pat and Peter are doing, and not a kind of tuning that could be incompatible.

Paolo

Follow-Ups:
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: H.J. Lu

References:
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Pat Haugen
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: H.J. Lu
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Peter Bergner
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Paolo Bonzini
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Peter Bergner
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: H.J. Lu
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Paolo Bonzini
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: H.J. Lu
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Jakub Jelinek
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]