This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p

From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
To: Peter Bergner <bergner at vnet dot ibm dot com>
Cc: "H.J. Lu" <hjl at lucon dot org>, Pat Haugen <pthaugen at us dot ibm dot com>, Paolo Bonzini <bonzini at gnu dot org>, Dave Korn <dave dot korn at artimi dot com>, gcc-patches at gcc dot gnu dot org, Ian Lance Taylor <iant at google dot com>, Rask Ingemann Lambertsen <rask at sygehus dot dk>, Richard Guenther <richard dot guenther at gmail dot com>
Date: Fri, 13 Jul 2007 08:19:37 +0200
Subject: Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
References: <20070626230126.GA14180@lucon.org> <OFCCCEC8E3.B30CC185-ON86257315.006E3FA2-86257315.006FC7FB@us.ibm.com> <20070711223208.GA31985@lucon.org> <1184203327.7983.60.camel@otta>
Reply-to: bonzini at gnu dot org

+  /* Group together equal REGs to do more simplification.  */
+  if (REG_P (x) && REG_P (y))
+    return REGNO (x) > REGNO (y);

If that doesn't help, then I suggest we add a target hook to
the changes in commutative_operand_precedence so that it
behaves the way it used to for everyone other than POWER6.

I think this is overkill. The change makes sense on every architecture.

Paolo

Follow-Ups:
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Peter Bergner

References:
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Pat Haugen
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: H.J. Lu
- Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
  - From: Peter Bergner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]