This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fwd: [ALL TARGETS] final patch for PR 25241
On 10/07/07, Janis Johnson <janis187@us.ibm.com> wrote:
> Regression tested and I also ran the framework tests. Further testing welcome!
My testing on powerpc64-linux for all languages but Ada showed no
surprises except that I needed to approve the change to pch/counter-2.c.
Thanks. That particular change is already committed to trunk, so
updating should fix that case.
> Unfortunately, I cannot test anything else apart from
> i686-pc-gnu-linux. Thus, some testcases that currently do nasty things
> (like matching multiple error/warnings with one dg-error or dg-warning
> directive) may break. Perhaps, there should be a short lock-down so
> people can test as many targets as possible.
It's OK to fix other problems as we find them, but wait a day to see if
there are any responses to the mail I sent to the gcc mailing list about
testsuite disruptions; as far as I'm concerned, this patch is OK (Manuel
and I have been discussing it for months now).
Mark has mentioned that he may lock-down trunk from time to time to
fix regressions. I think it would be better to commit this patch at
the start of one such lock-down, so we are sure that any failures are
discovered are due to the patch and not some regression. On the other
hand, I would like to commit it as soon as possible, to not give any
opportunity to other test to break meanwhile.
Cheers,
Manuel.