This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix PR tree-optimization/32589
> I like this a lot better though would suggest valid_gimple_rhs_p for the
> name (or is_valid_gimple_rhs).
I added "after_folding" to make it clear that the predicate is not recursive
like fold, i.e. you need to invoke it each time you call fold on GIMPLE
expressions to validate the result.
> Also in simplify_binary_expression PRE tries to select "useful" results, so
> the check for valid_gimple_rhs_p should be probably in addition to the
> existing ones,
Unless I'm mistaken, the checks are redundant.