This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [4.2/4.1] PR/32004, tree-ssa caused in/out asm constraints to often need reloads


> This patch is the official submission of the 4.1/4.2 version of my patch
> to fix PR32004.  The PR, an ice-on-valid caused by in/out asm
> constraints, is similar to PR21291 in spirit: in fact, the PR21291 test
> case did fail on 4.3 before my patch; on 4.1/4.2 instead a different
> test case is necessary, which was not reported by a user.
>
> [...]
>
> The patch is already there on 4.1 and 4.2, together with the fix to
> include PROP_REG_INFO.  The question is whether to leave it.
>
> Pros:
> - PR32004 is P1 at least according to the RM
>
> Cons:
> - the pass cannot be turned off with a command line flag

Thanks for the thorough summary.  I disagree with one thing though: the P1 
priority is IMO only valid for mainline, neither for 4.2 nor for 4.1 branch 
because no existing testcase in the testsuite or new testcase submitted by a 
user fails without your patch on either of these branches.

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]