This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PR/32004, tree-ssa caused in/out asm constraints to often need reloads

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Paolo Bonzini <bonzini at gnu dot org>
Cc: Andrew Pinski <pinskia at gmail dot com>, gcc-patches at gcc dot gnu dot org, Mark Mitchell <mark at codesourcery dot com>
Date: Mon, 9 Jul 2007 15:59:39 +0200
Subject: Re: PR/32004, tree-ssa caused in/out asm constraints to often need reloads
References: <468CC82F.2060702@lu.unisi.ch> <200707091455.31718.ebotcazou@adacore.com> <469231B2.3010503@gnu.org>

> I do believe the patch is trivial (note I didn't say obvious) if you
> investigated the failure mode.

I'd have said the opposite (it's an obvious fix but not a trivial change, 
because of the quirks of the dataflow engine) but I'm not a native speaker.

> Otherwise, I would very much prefer fixing PR21291/PR32004, which is as
> bad a regression as the one I introduced.  Of course, I'm not meaning
> I'm *not* sorry to have introduced a regression.

But PR21291/PR32004 was reported against 4.3 only!  A testcase was later found 
that fails with all 4.x compilers, but AFAICS it was not reported by a user.

So I still think that this patch should not have been put on the 4.1 branch.

-- 
Eric Botcazou

References:
- PR/32004, tree-ssa caused in/out asm constraints to often need reloads
  - From: Paolo Bonzini
- Re: PR/32004, tree-ssa caused in/out asm constraints to often need reloads
  - From: Eric Botcazou
- Re: PR/32004, tree-ssa caused in/out asm constraints to often need reloads
  - From: Paolo Bonzini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]