This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: add DOLLARS_IN_ASM_IDENTIFIERS


Sandra Loosemore <sandra@codesourcery.com> writes:

> Andrew Pinski wrote:
> > On 7/6/07, Sandra Loosemore <sandra@codesourcery.com> wrote:
> >> > This is OK if it passes bootstrap.
> >>
> >> Yup, committed now.  Thanks.
> > Which target did you test on?  Because you did not mention it.
> > Anyways this causes PR 32670 (a bootstrap failure on i686-linux-gnu
> > in libffi )
> > aka http://gcc.gnu.org/ml/gcc/2007-07/msg00233.html :
> 
> Huh.  I did bootstrap i686-pc-linux-gnu.  But, aha, our standard
> configuration for that has --enable-languages=c,c++, which explains
> why I didn't see the Java library failure.
> 
> If it turns out the committed version of the patch breaks things in
> ways that can't be fixed easily, I'm OK with reverting it and
> substituting the original version I prepared.  Or perhaps just
> reverting it and explicitly deciding that any code that depends on any
> particular behavior of the tokenizer in assembly language files is
> broken.  :-P

I think we have to revert the patch.  That error case did not occur to
me; sorry.  I believe the code in question is more or less broken, but
there is no spec in this area, and most likely other code is written
this way, and I don't think it's reasonable for us to break existing
code.

Does -fdollars-in-identifiers work for .S files?  Perhaps we should
just make sure that works and leave it at that.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]