This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
- From: Ian Lance Taylor <iant at google dot com>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: "H. J. Lu" <hjl at lucon dot org>, Richard Guenther <richard dot guenther at gmail dot com>, Paolo Bonzini <bonzini at gnu dot org>, Dave Korn <dave dot korn at artimi dot com>, Rask Ingemann Lambertsen <rask at sygehus dot dk>, gcc-patches at gcc dot gnu dot org, Pat Haugen <pthaugen at us dot ibm dot com>
- Date: 05 Jul 2007 23:30:00 -0700
- Subject: Re: [PING][PATCH][REVISED] Fix PR middle-end/PR28690, modify swap_commutative_operands_p
- References: <010d01c7ad15$780720c0$2e08a8c0@CAM.ARTIMI.COM> <1181670014.19229.74.camel@otta> <m3d501f3wg.fsf@localhost.localdomain> <4677F866.9070605@gnu.org> <20070620171738.GA22508@vervain.rchland.ibm.com> <20070621125523.GA12802@lucon.org> <84fc9c000706210616s4ae15ce9yf8767bdcdfcb5919@mail.gmail.com> <20070621141603.GA2063@lucon.org> <20070621141737.GA16120@lucon.org> <1182449655.6798.34.camel@otta> <20070626230126.GA14180@lucon.org> <m33b0ethxv.fsf@localhost.localdomain> <1183687236.5585.16.camel@otta>
Peter Bergner <bergner@vnet.ibm.com> writes:
> On Tue, 2007-06-26 at 16:27 -0700, Ian Lance Taylor wrote:
> > Peter's patch referenced above looks OK to me, and I'm inclined to
> > approve it. But some of these numbers do look troubling. Why do we
> > get such large swings in some of the benchmarks?
>
> Ian, on IRC you mentioned you thought the following patch was probably
> ok to commit.
>
> http://gcc.gnu.org/ml/gcc-patches/2007-06/msg01493.html
>
> Was that a formal approval?
Yes, this is OK.
Thanks.
Ian