RE: [CFARM] Script for automatic checking of patches

["Dave Korn" <dave dot korn at artimi dot com>]

On 03 July 2007 19:34, Laurent GUERBY wrote:

> On Tue, 2007-07-03 at 10:24 +0100, Dave Korn wrote:
>>> Okay, so why do you still trust commits to gcc trunk?  Do you check
>>> all the patches that go in during a 'svn up' before doing a bootstrap
>>> of the new tree?
>> 
>>   To the extent that they've been visually inspected as part of the review
>> process, and are accountable to known identities with an established
>> history when committed, yes.
> 
> I'm not familiar with gpg, but if the script checks by default for a
> valid signature of the patch file (either from the user keyring or from
> a directory to be populated with keys) I guess it's more acceptable for
> distribution? We can always provide a --no-check-signature to disable
> it.

  That's a good idea.  It could be as simple as adding a clause like


    if ! gpg -verify $TESTING/$PATCH ; then
	echo "$SCRIPT: your patch failed to verify:" >> $REPORT
	cat $TESTING/patching >> $REPORT
	return 1
    fi

to the setup function.

    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....