This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[Patch] 3/3 FFI: Use __builtin_flush_icache() to flush MIPS i-cache.
- From: David Daney <ddaney at avtrex dot com>
- To: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Sat, 30 Jun 2007 22:09:34 -0700
- Subject: [Patch] 3/3 FFI: Use __builtin_flush_icache() to flush MIPS i-cache.
- References: <468734D3.3020908@avtrex.com>
This is the third and final part of the __builtin_flush_icache patch.
It replaces the hard coded library call to cacheflush() in the MIPS
ffi_prep_closure_loc with a call to __builtin_flush_icache();
For targets that support user-space i-cache flushing (mips32r2), this
will eliminate a system call from the ffi closure preparation path.
On all other targets the generated code is the same as before.
Bootstrapped and tested on x86_64-unknown-linux-gnu all default
languages with no regressions.
Also tested on:
x86_64 cross to mipsel-linux --with-arch=mips32
i686 cross to mipsel-linux --with-arch=mips32r2
with no regressions.
OK to commit?
libffi/:
2007-06-30 David Daney <ddaney@avtrex.com>
* src/mips/ffi.c: Don't include sys/cachectl.h.
(ffi_prep_closure_loc): Use __builtin_flush_icache() instead of
cacheflush().
Index: src/mips/ffi.c
===================================================================
--- src/mips/ffi.c (revision 125997)
+++ src/mips/ffi.c (working copy)
@@ -27,7 +27,6 @@
#include <ffi_common.h>
#include <stdlib.h>
-#include <sys/cachectl.h>
#if _MIPS_SIM == _ABIN32
#define FIX_ARGP \
@@ -525,8 +524,7 @@ ffi_prep_closure_loc (ffi_closure *closu
closure->fun = fun;
closure->user_data = user_data;
- /* XXX this is available on Linux, but anything else? */
- cacheflush (codeloc, FFI_TRAMPOLINE_SIZE, ICACHE);
+ __builtin_flush_icache(codeloc, FFI_TRAMPOLINE_SIZE);
return FFI_OK;
}