This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Patch] 3/3 FFI: Use __builtin_flush_icache() to flush MIPS i-cache.

This is the third and final part of the __builtin_flush_icache patch.
It replaces the hard coded library call to cacheflush() in the MIPS
ffi_prep_closure_loc with a call to __builtin_flush_icache();

For targets that support user-space i-cache flushing (mips32r2), this
will eliminate a system call from the ffi closure preparation path.
On all other targets the generated code is the same as before.

Bootstrapped and tested on x86_64-unknown-linux-gnu all default
languages with no regressions.

Also tested on:
x86_64 cross to mipsel-linux --with-arch=mips32
i686   cross to mipsel-linux --with-arch=mips32r2

with no regressions.

OK to commit?

2007-06-30  David Daney  <>

   * src/mips/ffi.c: Don't include sys/cachectl.h.
   (ffi_prep_closure_loc): Use __builtin_flush_icache() instead of

Index: src/mips/ffi.c
--- src/mips/ffi.c	(revision 125997)
+++ src/mips/ffi.c	(working copy)
@@ -27,7 +27,6 @@
 #include <ffi_common.h>
 #include <stdlib.h>
-#include <sys/cachectl.h>
 #if _MIPS_SIM == _ABIN32
 #define FIX_ARGP \
@@ -525,8 +524,7 @@ ffi_prep_closure_loc (ffi_closure *closu
   closure->fun = fun;
   closure->user_data = user_data;
-  /* XXX this is available on Linux, but anything else? */
-  cacheflush (codeloc, FFI_TRAMPOLINE_SIZE, ICACHE);
+  __builtin_flush_icache(codeloc, FFI_TRAMPOLINE_SIZE);
   return FFI_OK;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]