This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Tuples] Cleaned up accessor patch.
> Looks fine to me. If we later realize that the iterator should hold a
> gimple * instead of gimple, we can change it again.
I assume you're talking about "gimple *ptr" in gimple_stmt_iterator.
We had a pointer there so gsi_stmt_ptr() would work, but Richard had
mentioned that there probably wasn't any point to gsi_stmt_ptr since we
couldn't replace statements anymore by storing into them.
I put a FIXME note on gsi_stmt_ptr, and left it there in case we needed
it.
If you also agree we won't need it, I say nuke it. Please adjust
everything accordingly in gimple-iterator.*, and make sure you run cc1
over all the gimple tests in gcc.dg/gimple/.
Aldy