This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 32460 - Check PRIVATE attribute for derived components
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: Bernhard Fischer <rep dot dot dot nop at gmail dot com>, "'fortran at gcc dot gnu dot org'" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 24 Jun 2007 09:12:11 -0700
- Subject: Re: [Patch, Fortran] PR 32460 - Check PRIVATE attribute for derived components
- References: <467D4555.7080706@net-b.de> <20070623195127.GN4096@aon.at> <467DBB96.4080805@net-b.de>
On Sun, Jun 24, 2007 at 02:32:22AM +0200, Tobias Burnus wrote:
> Bernhard Fischer wrote:
> >> + int private_comp = 0;
> >>
> > bool?
> >
> Good idea. I had somehow back in my mind that the GCC source does not
> use bool as they were added quite late to the C standard (similar like
> not using C99's // comments). But as bool is already used more than 300
> times it surely must work. Thanks for pointing out!
>
> Would like like to formally review the patch - or did you do so alreay
> and only forgot the "Ok"?
>
> Updated patch attached. (I fixed also gcc/fortran/dump-parse-tree.c
> which did not print "PUBLIC" in the parse-tree dump.)
>
Whoops. I replied to Bernhard's email with the OK.
OK for trunk.
--
Steve