This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Bug tree-optimization/32461] [4.3 Regression] Segmentation fault in build_classic_dist_vector_1() at tree-data-ref.c:2700

On 6/24/07, Sebastian Pop <sebpop@gmail.com> wrote: 
On 6/24/07, Sebastian Pop <sebpop@gmail.com> wrote:
> So this just looks like we want to improve operand_equal_p, and not
> touch the folder this time.  Probably we can implement one more flag
> for stripping nop conversions of operands.
>

Actually I think that the test in operand_equal_p is too strong for
our case where the expression under the nops is just an SSA_NAME.

Would a patch like the following one be acceptable?  I've put this
patch to bootstrap and test with --enable-checking=yes,fold,rtl.


I think you just made oep_can_strip_nops too lose. I think you just
need to strip the NOPs off the call to operand_equal_p when doing a +
~a (and ~a + a) folding.  Or maybe use op1/op0 instead.  I don't think
it is safe to strip NOPs even for SSA_NAMES in operand_equal_p.

Thanks,
Andrew Pinski

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]